AGENT-742: Add baremetal host BMC configuration to install-config #1601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the agent installer, add fields to install-config.yaml for the BMC and provisioning network. This allows baremetal hosts to be set up at install time.
|
It wasn't obvious to me from looking at this PR alone. To test this, you'll need to set |
|
/retest-required |
|
That makes sense :)
…On Wed, 29 Nov 2023, 04:47 Bob Fournier, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In agent/roles/manifests/templates/install-config_baremetal_yaml.j2
<#1601 (comment)>
:
> hosts:
{% for hostname in hostnames %}
- name: {{ hostname }}
bootMACAddress: {{ macs[loop.index0] }}
+ bmc:
+ address: {{ bmc_addresses[loop.index0] }}
+ username: {{ bmc_usernames[loop.index0] }}
+ password: {{ bmc_passwords[loop.index0] }}
+ disableCertificateVerification: false
Thanks @ahussey-redhat <https://github.com/ahussey-redhat>. So this
setting doesn't affect the installation or the resulting baremetalhosts,
and making it configurable would just require a new environment variable
which wouldn't be used in any CI tests so I don't think we need it to be
configurable.
—
Reply to this email directly, view it on GitHub
<#1601 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWGJ7GF3QK7YQJDAJFPANWDYGYPRHAVCNFSM6AAAAAA7DCKSSCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONJTGUZDGMZSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
andfasano
reviewed
Dec 5, 2023
|
/retest |
|
/test e2e-metal-ipi-ovn-dualstack |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-metal-ipi-serial-ipv4 |
|
/retest-required |
openshift-merge-bot
bot
merged commit 0cb0bb7
into
openshift-metal3:master
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the agent installer, add fields to install-config.yaml for the BMC and provisioning network. This allows baremetal hosts to be set up at install time.