Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable libvirt proxy local socket #1607

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable libvirt proxy local socket #1607

wants to merge 1 commit into from

Conversation

psathyan
Copy link
Contributor

We have observed the below error in some of our deployments.

2023-11-23 15:20:02 level=error msg=Error: failed to dial libvirt: dial unix /var/run/libvirt/libvirt-sock: connect: no such file or directory

Using this patch, we are able to proceed when the above error is observed. Newer deployments with this patch have been successful.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 24, 2023

Hi @psathyan. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 24, 2023
psathyan added a commit to psathyan/ci-framework that referenced this pull request Nov 24, 2023
@psathyan
Patch dev-scripts repository for improving libvirt stability
7718557 
This PR includes a proposed a patch (1607)
[openshift-metal3/dev-scripts#1607]

that may improve the reliability of OCP deployment and avoid
observing the below error

2023-11-23 15:20:02 level=error msg=Error: failed to dial libvirt:
dial unix /var/run/libvirt/libvirt-sock: connect: no such file or
directory

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
@psathyan psathyan mentioned this pull request Nov 24, 2023
Merged
1 task
dtantsur
dtantsur reviewed Nov 26, 2023
View reviewed changes
02_configure_host.sh Outdated Show resolved Hide resolved
dtantsur
dtantsur reviewed Nov 26, 2023
View reviewed changes
02_configure_host.sh Outdated Show resolved Hide resolved
@dtantsur
Copy link
Member

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2023
@psathyan
Copy link
Contributor Author

psathyan commented Dec 1, 2023

/test e2e-metal-ipi-ovn-dualstack

eshulman2 pushed a commit to eshulman2/ci-framework that referenced this pull request Dec 10, 2023
@psathyan
Patch dev-scripts repository for improving libvirt stability
758b960 
This PR includes a proposed a patch (1607)
[openshift-metal3/dev-scripts#1607]

that may improve the reliability of OCP deployment and avoid
observing the below error

2023-11-23 15:20:02 level=error msg=Error: failed to dial libvirt:
dial unix /var/run/libvirt/libvirt-sock: connect: no such file or
directory

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
eshulman2 pushed a commit to eshulman2/ci-framework that referenced this pull request Dec 12, 2023
@psathyan
Patch dev-scripts repository for improving libvirt stability
e636071 
This PR includes a proposed a patch (1607)
[openshift-metal3/dev-scripts#1607]

that may improve the reliability of OCP deployment and avoid
observing the below error

2023-11-23 15:20:02 level=error msg=Error: failed to dial libvirt:
dial unix /var/run/libvirt/libvirt-sock: connect: no such file or
directory

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
@psathyan
Copy link
Contributor Author

/test e2e-metal-ipi-bm-bond

bshephar
bshephar approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@bshephar bshephar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirming that this also works for me.

@psathyan psathyan mentioned this pull request Feb 17, 2024
Merged
9 tasks
@psathyan
Copy link
Contributor Author

psathyan commented Mar 5, 2024

/retest

@psathyan psathyan mentioned this pull request Mar 8, 2024
Open
@psathyan
Copy link
Contributor Author

psathyan commented Mar 8, 2024

/retest-required

2 similar comments
@psathyan
Copy link
Contributor Author

psathyan commented Mar 9, 2024

/retest-required

@psathyan
Copy link
Contributor Author

/retest-required

@psathyan
Copy link
Contributor Author

/retest-required

@psathyan
Copy link
Contributor Author

/retest-required

@psathyan
Enable libvirt proxy local socket
a3a8ea9 
2023-11-23 15:20:02 level=error msg=Error: failed to dial
libvirt: dial unix /var/run/libvirt/libvirt-sock: connect: no
such file or directory

There some lingering runs having the above error message. Hence,
enabling virtproxyd service

Signed-off-by: Pragadeeswaran Sathyanarayanan <psathyan@redhat.com>
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 28, 2024 •
edited

@psathyan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack a3a8ea9 link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-virtualmedia a3a8ea9 link false /test e2e-metal-ipi-virtualmedia
ci/prow/e2e-metal-ipi-bm-bond a3a8ea9 link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 a3a8ea9 link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

mkowalski
mkowalski approved these changes May 3, 2024
View reviewed changes
Copy link
Member

@mkowalski mkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and this fixes dev-scripts on a fresh Stream 9 installations

@mkowalski
Copy link
Member

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mkowalski
Once this PR has been reviewed and has the lgtm label, please assign celebdor for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psathyan
Copy link
Contributor Author

psathyan commented May 4, 2024

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkowalski mkowalski mkowalski approved these changes

@bshephar bshephar bshephar approved these changes

@andfasano andfasano Awaiting requested review from andfasano

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@mkowalski mkowalski

Labels
lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@psathyan @dtantsur @mkowalski @bshephar