Assign OPENSHIFT_VERSION early if not manually defined

[elfosardo]

No description provided.

[elfosardo]

/retest

[dtantsur]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dtantsur]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[elfosardo]

/retest

[elfosardo]

/retest

[openshift-ci]

@elfosardo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-agent-ha-dualstack	b885ada	link	false	/test e2e-agent-ha-dualstack
ci/prow/e2e-metal-ipi-bm-bond	b885ada	link	false	/test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ovn-ipv6	b885ada	link	false	/test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[zaneb]

This is dragging us deeper and deeper into dependency hell.

I created release_info.sh so that we would not have to include it everywhere that utils.sh is used.
This patch is now including both release_info.sh and utils.sh in common.sh so that basically every function is available everywhere and you have to have all of the data in the system in your head to know if any of it is going to work.

Bash is a horrible language to write something this big in. What we have now is borderline unmaintainable. This is going in exactly the wrong direction IMHO and I fear it will push us right over the edge. We need to make it more modular over time and not throw everything in one big pot.

[elfosardo]

/hold
I'm not happy either about this, I was looking for a way to just get OPENSHIFT_VERSION early during the run to be available for the entire process, but at some point we got in a dependency loop.
Besides the fact that bash is definitely not the right way to go, we should find an alternative to provide all the needed info, especially a basic one like the running openshift version, at the start of the script.
I won't continue this, but I'll leave it here for the time being just as a reminder of the current status of dev-scripts.