CORS-3462: extract static openshift-installer from 4.16 #1653
Conversation
zaneb
force-pushed
the
openshift-install-cmd
branch
from
b017531
to
4601421
Compare
|
This is a potential alternative to #1651 |
|
/cc @r4f4, @elfosardo |
Dynamically determine the installer command to extract from the payload. After extraction, rename it to "openshift-install" so that we always have a consistent command name, regardless of what was extracted or if we built it locally.
This allows us to continue to run on RHEL/CentOS 8. openshift-baremetal-install will be dynamically linked for RHEL 9 starting with 4.16.
zaneb
force-pushed
the
openshift-install-cmd
branch
from
4601421
to
b87cca2
Compare
|
LGTM |
|
/retest-required |
|
/lgtm |
|
/retest |
Only do this if FIPS_VALIDATE is set to true, otherwise this will break the ability to test FIPS on RHEL/CentOS 8 with OCP 4.16 and later.
zaneb
force-pushed
the
openshift-install-cmd
branch
from
b87cca2
to
2ac6e79
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/lgtm |
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/test e2e-metal-ipi-serial-ipv4 |
openshift-merge-bot
bot
merged commit 9d1a83c
into
openshift-metal3:master
With openshift/installer#8161, the baremetal installer is now part of the regular installer which is now statically linked.
Using the static binary has the advantage of working on both CS8 and CS9 VMs and is a necessary step for moving the Installer images to a RHEL9 base.