Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up the node -> machine mapping #286

Merged
merged 1 commit into from Apr 9, 2019
Merged

Set up the node -> machine mapping #286

merged 1 commit into from Apr 9, 2019

Conversation

bcrochet
Copy link
Contributor

@bcrochet bcrochet commented Apr 3, 2019

This manually updates the status of the Machine objects to contains:

  1. nodeRef pointing back to the Node
  2. addresses of the Node, copied to the Machine

russellb
russellb reviewed Apr 3, 2019
View reviewed changes
08_deploy_bmo.sh Outdated Show resolved Hide resolved
russellb
russellb reviewed Apr 3, 2019
View reviewed changes
08_deploy_bmo.sh Outdated Show resolved Hide resolved
@bcrochet bcrochet force-pushed the node-machine branch 3 times, most recently from 0e20833 to b4d9d26 Compare April 3, 2019 21:15
russellb
russellb requested changes Apr 3, 2019
View reviewed changes
08_deploy_bmo.sh Outdated Show resolved Hide resolved
@bcrochet bcrochet force-pushed the node-machine branch 3 times, most recently from 784353e to a030b25 Compare April 3, 2019 21:31
@derekhiggins
Copy link
Collaborator

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/518/

@bcrochet bcrochet force-pushed the node-machine branch 2 times, most recently from 4220ae0 to 6e3c507 Compare April 5, 2019 20:13
russellb
russellb requested changes Apr 5, 2019
View reviewed changes
06_create_cluster.sh Outdated Show resolved Hide resolved
06_create_cluster.sh Show resolved Hide resolved
@bcrochet bcrochet force-pushed the node-machine branch 3 times, most recently from 9c45bc3 to 66072c8 Compare April 5, 2019 21:02
@russellb russellb added the CI check this PR with CI label Apr 5, 2019
@derekhiggins
Copy link
Collaborator

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/538/

@derekhiggins
Copy link
Collaborator

Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/540/

@bcrochet
WIP: Set up the node -> machine mapping
82d996e 
This manually updates the status of the Machine objects to contains:

1) nodeRef pointing back to the Node
2) addresses of the Node, copied to the Machine
@derekhiggins
Copy link
Collaborator

Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/541/

@dhellmann
Copy link
Member

LGTM. I'll leave it for Russell to formally approve, since he had changes requested.

@hardys hardys mentioned this pull request Apr 9, 2019
Merged
russellb
russellb approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We'll still have this problem on workers once those are working, but we can deal with that later.

@russellb russellb merged commit b09aaf2 into openshift-metal3:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb approved these changes

Assignees
No one assigned
Labels
CI check this PR with CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bcrochet @derekhiggins @dhellmann @russellb