Remove some cert approval related hacks. #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/922/ |
|
Workers are failing to come up: Do we need some logic to check if bmo pods are up first? |
The register_hosts script used to wait for a worker to come up, but I removed it since I didn't see anything that required waiting. It makes sense for CI purposes, though. I'll add something to |
russellb
changed the title
This patch cleans up some hacks that are no longer needed. CSRs for masters are automatically approved by a service runningon the bootstrap node during the bootstrap process. Workers is where we are still missing some pieces. Move the fix-certs cron job to the register_hosts script, which is where worker deployment is kicked off. Also remove the add-machine-ips and link-machine-and-node scripts. cluster-api-provider-baremetal should now be automatically populating the addresses field of Machines based on introspection data it gets out of the BareMetalHost object for workers. Removing these scripts ensures we only rely on that code, and not a dev-script hack. The reigster_hosts script no longer waits for the worker to come up, since it's not required and the cluster should already be functional by this point. The run_ci script was updated to ensure the worker comes up to still make sure this case is tested.
russellb
force-pushed
the
csr-hack-cleanup
branch
from
35a8fcc
to
a991cca
Compare
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/925/ |
russellb
changed the title
|
CI passes now. :-) |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch cleans up some hacks that are no longer needed. CSRs for
masters are automatically approved by a service runningon the
bootstrap node during the bootstrap process.
Workers is where we are still missing some pieces. Move the fix-certs
cron job to the register_hosts script, which is where worker
deployment is kicked off.
Also remove the add-machine-ips and link-machine-and-node scripts.
cluster-api-provider-baremetal should now be automatically populating
the addresses field of Machines based on introspection data it gets
out of the BareMetalHost object for workers. Removing these scripts
ensures we only rely on that code, and not a dev-script hack.
Related to issue #260.