Convert OS Image cache to use new install-config interface #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @kirankt FYI |
stbenjam
reviewed
Dec 18, 2019
kirankt
reviewed
Dec 18, 2019
kirankt
reviewed
Dec 18, 2019
hardys
changed the title
|
coreos/coreos-assembler#1006 landed but we still need an RHCOS bump to avoid the "not in gzip format" error from rhcos-downloader on the virthost. Merging this may be the quickest workaround for that, I'll fix up the MIRROR_IP and see if CI passes. |
Since openshift/installer#2757 merged we can mirror the installer referenced images directly to simulate typical disconnected install scenarios. This removes some complexity as we no longer need to run the downloader container on the host, only expose the unprocessed images via http. Note this will work with latest 4.4. builds but not 4.3 until openshift/installer#2835 lands
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1388/ |
stbenjam
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since openshift/installer#2757
merged we can mirror the installer referenced images directly
to simulate typical disconnected install scenarios.
This removes some complexity as we no longer need to run the
downloader container on the host, only expose the unprocessed images
via http.
Note this will work with latest 4.4. builds but not 4.3 until
openshift/installer#2835 lands