End-to-end test with minimal configmap #897
Conversation
stbenjam
force-pushed
the
test-end-to-end
branch
from
81454ab
to
04a0454
Compare
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1443/ |
stbenjam
force-pushed
the
test-end-to-end
branch
from
0b499ea
to
332f8dc
Compare
|
Build ABORTED, see build http://10.8.144.11:8080/job/dev-tools/1444/ |
ocp_install_env.sh
Outdated
| controlPlane: | ||
| name: master | ||
| replicas: ${NUM_MASTERS} | ||
| platform: | ||
| baremetal: {} | ||
| platform: | ||
| baremetal: | ||
| provisioningNetworkInterface: "enp1s0" |
There was a problem hiding this comment.
@hardys The default in openshift/installer is ens3, but that's wrong for dev-scripts. I wonder if we should even have a default value for this field, as it's really hardware and environment-specific, what do you think?
There was a problem hiding this comment.
Yeah I guess it makes sense to remove the default, I commented on the installer PR though as I think we have to make it very clear what the needed info is there when folks invariably don't initially include it.
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1445/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1446/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1447/ |
|
Hm, the last one may just have been a timeout due to how long it takes to deploy masters and workers in the installer. Mine passed locally (barely). Both PR's are merged, will have a look tomorrow morning once it's available in a CI build. |
stbenjam
force-pushed
the
test-end-to-end
branch
3 times, most recently
from
b7448d8
to
12177e6
Compare
stbenjam
changed the title
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1450/ |
|
Build FAILURE, see build http://10.8.144.11:8080/job/dev-tools/1451/ |
With the exception of RHCOS image url, this configures Metal3 using the Provisioning CR from MAO, and deploys workers as part of the install.
stbenjam
force-pushed
the
test-end-to-end
branch
from
12177e6
to
5c38184
Compare
|
Build SUCCESS, see build http://10.8.144.11:8080/job/dev-tools/1453/ |
| # TODO - Change worker replicas to ${NUM_WORKERS} once the machine-api-operator | ||
| # deploys the baremetal-operator | ||
| deploy_kernel=$(node_val 0 "driver_info.deploy_kernel") | ||
| deploy_ramdisk=$(node_val 0 "driver_info.deploy_ramdisk") |
There was a problem hiding this comment.
Is this still used anywhere? I think we can remove it?
| echo " hardwareProfile: ${MASTER_HARDWARE_PROFILE:-default}" | ||
| else | ||
| echo " hardwareProfile: ${WORKER_HARDWARE_PROFILE:-unknown}" | ||
| fi |
There was a problem hiding this comment.
As a note for any other reviewers this will be fixed by openshift/installer#2969
With the exception of RHCOS image url, this configures Metal3 using the
Provisioning CR from MAO, and deploys workers as part of the install.