This repository has been archived by the owner on Jul 23, 2019. It is now read-only.
Rewrite terraform to support dynamic number of nodes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stbenjam
reviewed
Apr 16, 2019
There was a problem hiding this comment.
I get some errors trying to run this - it looks like the main.tf in the root of the directory was overwritten by the one that should be in masters/
level=error msg="Error: resource 'ironic_node_v1.openshift-master' count: unknown variable referenced: 'master_nodes'; define it with a 'variable' block"
level=error
level=error
level=error
level=error msg="Error: resource 'ironic_node_v1.openshift-master' config: unknown variable referenced: 'image_source'; define it with a 'variable' block"
level=error
level=error
level=error
level=error msg="Error: resource 'ironic_node_v1.openshift-master' config: unknown variable referenced: 'root_gb'; define it with a 'variable' block"
level=error
yrobla
force-pushed
the
rewrite_terraform
branch
4 times, most recently
from
d965631
to
08f62c8
Compare
stbenjam
reviewed
Apr 16, 2019
yrobla
force-pushed
the
rewrite_terraform
branch
from
08f62c8
to
5c20fe4
Compare
stbenjam
reviewed
Apr 17, 2019
yrobla
force-pushed
the
rewrite_terraform
branch
from
5c20fe4
to
94b887e
Compare
stbenjam
approved these changes
Apr 17, 2019
Change the data structure to accept data of nodes using maps. This will allow to add a variable number of masters (1,3) in the future. Added a new dependency on rodaine/hclencoder, to render terraform data in HCL instead of JSON, to avoid a bug in JSON parsing: hashicorp/terraform#15549
yrobla
force-pushed
the
rewrite_terraform
branch
from
94b887e
to
9244d23
Compare
hardys
approved these changes
Apr 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the data structure to accept data of nodes using maps.
This will allow to add a variable number of masters (1,3) in the future.
Added a new dependency on rodaine/hclencoder, to render terraform data
in HCL instead of JSON, to avoid a bug in JSON parsing:
hashicorp/terraform#15549