Skip to content

Commit

Permalink
UPSTREAM: <carry>: Lower flake attempts to 3
Browse files Browse the repository at this point in the history
If a test can't pass in 3 attempts we probably shouldn't consider
that acceptable anyway, and 5 flakes on some longer tests causes us
to exceed the timeout for CI jobs, which means we don't even
attempt to run all of the tests.

(cherry picked from commit a2b4862)
Signed-off-by: Mat Kowalski <mko@redhat.com>
  • Loading branch information
cybertron authored and mkowalski committed Jun 21, 2023
1 parent b29ee80 commit bc0e7d1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion hack/ocp-e2e-tests-handler.sh
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export KUBEVIRTCI_RUNTIME="${KUBEVIRTCI_RUNTIME:-podman}"
export PRIMARY_NIC=enp2s0
export FIRST_SECONDARY_NIC=enp3s0
export SECOND_SECONDARY_NIC=enp4s0
export FLAKE_ATTEMPTS="${FLAKE_ATTEMPTS:-5}"
export FLAKE_ATTEMPTS="${FLAKE_ATTEMPTS:-3}"

SKIPPED_TESTS="user-guide|bridged|\
when desiredState is updated with ovs-bridge with linux bond as port" # https://bugzilla.redhat.com/show_bug.cgi?id=2005240 is not yet fixed in nmstate 1.2
Expand Down
2 changes: 1 addition & 1 deletion hack/ocp-e2e-tests-operator.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export KUBEVIRT_PROVIDER=external
export IMAGE_BUILDER="${IMAGE_BUILDER:-podman}"
export DEV_IMAGE_REGISTRY="${DEV_IMAGE_REGISTRY:-quay.io}"
export KUBEVIRTCI_RUNTIME="${KUBEVIRTCI_RUNTIME:-podman}"
export FLAKE_ATTEMPTS="${FLAKE_ATTEMPTS:-5}"
export FLAKE_ATTEMPTS="${FLAKE_ATTEMPTS:-3}"

if [ "${CI}" == "true" ]; then
source ${SHARED_DIR}/fix-uid.sh
Expand Down

0 comments on commit bc0e7d1

Please sign in to comment.