expose kubeconfig flag to run the agent binary on a host #94
Conversation
Signed-off-by: Wei Liu <liuweixa@redhat.com>
|
/cc @clyang82 |
Signed-off-by: Wei Liu <liuweixa@redhat.com>
| glog.Fatalf("error running command: %v", err) | ||
| workOptions.WorkloadSourceDriver = "mqtt" | ||
| // use manifest as the default codec | ||
| workOptions.CloudEventsClientCodecs = []string{"manifest"} |
There was a problem hiding this comment.
Could you update to support manifest and manifestbundle by default?
There was a problem hiding this comment.
I'm not sure, we should enable both codecs at the same time, for maestro, it should only handle the manifest, right?
There was a problem hiding this comment.
Let us handle it in separate issue #96
| func NewAgentOptions() *AgentOptions { | ||
| workOptions := spoke.NewWorkloadAgentOptions() | ||
| // use 1M as the default limit for state feedback | ||
| workOptions.MaxJSONRawLength = 1024 * 1024 |
There was a problem hiding this comment.
I remembered it was set in agent options. Do you need to reset it again?
There was a problem hiding this comment.
yes, but the default value is small for maestro case, we need increase it here
| o.WorkOptions.WorkloadSourceDriver, "Message broker type") | ||
| fs.StringVar(&o.WorkOptions.CloudEventsClientID, "agent-client-id", | ||
| o.WorkOptions.CloudEventsClientID, "The ID of the agent client, by default it is <consumer-id>-work-agent") | ||
| fs.StringSliceVar(&o.WorkOptions.CloudEventsClientCodecs, "agent-client-codecs", |
There was a problem hiding this comment.
can we propagate that up to the agent template https://github.com/openshift-online/maestro/blob/e3bdb59e5444b1e87b0a28828e0ae59d034f010c/templates/agent-template.yml ?
|
/hold |
|
we need to use library-go to implement this to support lease election |
No description provided.