Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve help and positional arg enforcement in most commands #161

Merged
merged 4 commits into from
Oct 23, 2020
Merged

Improve help and positional arg enforcement in most commands #161

merged 4 commits into from
Oct 23, 2020

Commits on Oct 13, 2020

  1. bump cobra to v1.0.0

    @cben
    cben committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    4458e59 View commit details
    Browse the repository at this point in the history

  2. Improve help and positional arg enforcement in most commands 

    Chosen approach explained in spf13/cobra#571 (comment)

Didn't touch the generic REST commands such as `get`, `delete` etc
as I'm confused by them both using `urls.Expand()` to support
`get URL` & `get KIND ID` forms, as well as having some Cobra sub-commands.
    @cben
    cben committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    0fb4b8c View commit details
    Browse the repository at this point in the history

  3. Mention --cluster=EXTERNAL_ID option in flag description

    @cben
    cben committed Oct 13, 2020
    Configuration menu
    Copy the full SHA
    10ef79f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2020

  1. Correct usage line for ocm list machinepools

    @cben
    cben committed Oct 14, 2020
    Configuration menu
    Copy the full SHA
    46f87d6 View commit details
    Browse the repository at this point in the history