OCM-4962 | Feat | Add OAuth login using PKCE #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirthct
commented
Jan 10, 2024
|
LGTM - let's plan to merge early next week |
tylercreller
approved these changes
Jan 24, 2024
gdbranco
approved these changes
Jan 25, 2024
|
@tirthct is this something that we can test? There are a few tests already for the |
Since oauth code flow requires user interaction (successful login in Red Hat sso) to get the token, we cannot generate an automated test here. However, we have tested the functionality in ocm-sdk as an example here : https://github.com/openshift-online/ocm-sdk-go/blob/main/examples/verify_authentication.go |
|
LGTM |
tylercreller
added a commit
to tylercreller/ocm-cli
that referenced
this pull request
Feb 6, 2024
* OCM-4962 | Feat | Add OAuth login using PKCE (openshift-online#590) * OCM-5759 | feat: Add Device Code Flow (openshift-online#591) * OCM-5281 | Feat | Add region validation from ocm-shards and list regions command (openshift-online#586) * Add region validation from ocm-shards and list regions command * Fixed mior debug changes * Marked rh region list flag hidden in cmd * Formatting change in example section in cmd file * OCM-4964: Secure store config * OCM-4964: Go mod tidy * OCM-4964: go mod tidy * OCM-4964: Secure store updates * OCM-4965: Use keyring for oauth flows * Temp: modify pub/release for testing * Add auth method password * Missed auth method test --------- Co-authored-by: tirthct <tithakka@redhat.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
Tested