Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-33257: Fix loader for start pipeline and add trigger modal #100

Merged

Conversation

vikram-raj
Copy link
Member

Before:

loading-modal-before.mov

After:

loadingmodal-After.mov

@openshift-ci openshift-ci bot requested review from saumeya and vdemeester May 3, 2024 14:23
@openshift-ci openshift-ci bot added the approved label May 3, 2024
@vikram-raj vikram-raj changed the title Fix loader for start pipeline and add trigger modal OCPBUGS-33257: Fix loader for start pipeline and add trigger modal May 3, 2024
@openshift-ci-robot
Copy link
Collaborator

@vikram-raj: This pull request references Jira Issue OCPBUGS-33257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

loading-modal-before.mov

After:

loadingmodal-After.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@vikram-raj: This pull request references Jira Issue OCPBUGS-33257, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Before:

loading-modal-before.mov

After:

loadingmodal-After.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikram-raj vikram-raj requested review from lokanandaprabhu and removed request for vdemeester and saumeya May 3, 2024 14:28
@vikram-raj
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lokanandaprabhu,vikram-raj]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5f12142 into openshift-pipelines:main May 3, 2024
9 checks passed
@openshift-ci-robot
Copy link
Collaborator

@vikram-raj: Jira Issue OCPBUGS-33257: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-33257 has been moved to the MODIFIED state.

In response to this:

Before:

loading-modal-before.mov

After:

loadingmodal-After.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vikram-raj vikram-raj deleted the loading-modal branch May 3, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants