Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SRVKP-4088: [main] tune multiarch container image build time #65

Merged

Conversation

jkandasa
Copy link
Member

@jkandasa jkandasa commented Feb 11, 2024

  • performing yarn install on multiarch with docker buildx takes a lot of time (approx 2h30m)
    to avoid this, yarn install and yarn build should be executed outside of docker (on a host platform)
    and only copy the dist to different platform/architecture runtime containers
    WARNING: with this approach, if we use platform native package may lead to a malfunction
    however in this project, the code will be executed on a browser and assuming there is no platform specific implementations, hence assuming no impact on this approach

  • and builds the container image for release-v* branches

@jkandasa
Copy link
Member Author

cc @vdemeester

Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Feb 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkandasa, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jkandasa jkandasa changed the title [main] tune multiarch container image build time SRVKP-4088: [main] tune multiarch container image build time Feb 12, 2024
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Feb 12, 2024

@jkandasa: This pull request references SRVKP-4088 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • performing yarn install on multiarch with docker buildx takes a lot of time (approx 2h30m)
    to avoid this, yarn install and yarn build should be executed outside of docker (on a host platform)
    and only copy the dist to different platform/architecture runtime containers
    WARNING: with this approach, if we use platform native package may lead to a malfunction
    however in this project, the code will be executed on a browser and assuming there is no platform specific implementations, hence assuming no impact on this approach

  • and builds the container image for release-v* branches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit b90fcb4 into openshift-pipelines:main Feb 12, 2024
9 checks passed
@jkandasa jkandasa deleted the update_multi_arch branch February 12, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants