-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRVKP-4088: [main] tune multiarch container image build time #65
SRVKP-4088: [main] tune multiarch container image build time #65
Conversation
cc @vdemeester |
1a288b5
to
9c3b2e4
Compare
Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
9c3b2e4
to
cfb645a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkandasa, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jkandasa: This pull request references SRVKP-4088 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
b90fcb4
into
openshift-pipelines:main
performing
yarn install
on multiarch withdocker buildx
takes a lot of time (approx2h30m
)to avoid this,
yarn install
andyarn build
should be executed outside of docker (on a host platform)and only copy the
dist
to different platform/architecture runtime containersWARNING: with this approach, if we use platform native package may lead to a malfunction
however in this project, the code will be executed on a browser and assuming there is no platform specific implementations, hence assuming no impact on this approach
and builds the container image for
release-v*
branches