Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31745: TaskRun status is not displayed near the name #90

Conversation

lokanandaprabhu
Copy link
Contributor

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31745

Analysis / Root cause:
Status was not added for TaskRun details page heading

Solution Description:
Added the status value in heading

Screen shots / Gifs for design review:

---Before--
Screenshot 2024-04-10 at 12 16 18 PM

--After--
Screenshot 2024-04-10 at 12 09 12 PM

Unit test coverage report:
NA

Test setup:

1. Create a TaskRun and go to details page

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

@openshift-ci-robot
Copy link
Collaborator

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-31745, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31745

Analysis / Root cause:
Status was not added for TaskRun details page heading

Solution Description:
Added the status value in heading

Screen shots / Gifs for design review:

---Before--
Screenshot 2024-04-10 at 12 16 18 PM

--After--
Screenshot 2024-04-10 at 12 09 12 PM

Unit test coverage report:
NA

Test setup:

  1. Create a TaskRun and go to details page

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: sanketpathak.

Note that only openshift-pipelines members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

@lokanandaprabhu: This pull request references Jira Issue OCPBUGS-31745, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31745

Analysis / Root cause:
Status was not added for TaskRun details page heading

Solution Description:
Added the status value in heading

Screen shots / Gifs for design review:

---Before--
Screenshot 2024-04-10 at 12 16 18 PM

--After--
Screenshot 2024-04-10 at 12 09 12 PM

Unit test coverage report:
NA

Test setup:

  1. Create a TaskRun and go to details page

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lokanandaprabhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lokanandaprabhu
Copy link
Contributor Author

/retest

Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Apr 11, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 2315f9a into openshift-pipelines:main Apr 11, 2024
9 checks passed
@openshift-bot
Copy link

@lokanandaprabhu: Jira Issue OCPBUGS-31745: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-31745 has not been moved to the MODIFIED state.

In response to this:

Fixes:
https://issues.redhat.com/browse/OCPBUGS-31745

Analysis / Root cause:
Status was not added for TaskRun details page heading

Solution Description:
Added the status value in heading

Screen shots / Gifs for design review:

---Before--
Screenshot 2024-04-10 at 12 16 18 PM

--After--
Screenshot 2024-04-10 at 12 09 12 PM

Unit test coverage report:
NA

Test setup:

  1. Create a TaskRun and go to details page

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lokanandaprabhu
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@lokanandaprabhu: only openshift-pipelines org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Collaborator

Fix included in accepted release 4.16.0-0.nightly-2024-04-13-070448

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants