Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the condition in watcher when to user repo secret #1100

Merged
merged 2 commits into from Jan 11, 2023

Conversation

sm43
Copy link
Contributor

@sm43 sm43 commented Jan 10, 2023

we fixed this bug in controller but not in watcher, where we look for secret in repo cr only if the event is not from github app. this fixes the conditions for watcher.

Signed-off-by: Shivam Mukhade smukhade@redhat.com

Changes

Submitter Checklist

  • β™½ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • πŸ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • πŸ§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • πŸ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

we fixed this bug in controller but not in watcher, where
we look for secret in repo cr only if the event is not from
github app. this fixes the conditions for watcher.

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@chmouel
Copy link
Member

chmouel commented Jan 10, 2023

πŸ’― 🎯

feel free to merge it when CI is green.

this fixes following lint error
./docs/content/docs/guide/resolver.md:103:36 MD034/no-bare-urls Bare URL used [Context: "http://"]
./docs/content/docs/guide/resolver.md:103:47 MD034/no-bare-urls Bare URL used [Context: "https://"]

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@sm43 sm43 merged commit 600ab9e into openshift-pipelines:main Jan 11, 2023
@sm43 sm43 deleted the fix-repo-cr-secret-bug branch January 11, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants