Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a check to watch on secret pipelines-as-code-secret to decide GithubApp or Webhook #1177

Merged

Conversation

savitaashture
Copy link
Member

Changes

Fixes: https://issues.redhat.com/browse/SRVKP-2885

tkn-pac create repo should not configure webhook when GithubApp is installed but right now PAC relaying on pipelines-as-code-info configmap for Provider key here and if Provider is "" even though secret pipelines-as-code-secret present tkn-pac create repo does not know about secret info and it tries for Webhook

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

@chmouel
Copy link
Member

chmouel commented Mar 7, 2023

this looks good but we really need to take the opportunity to add unittests for this file (configmap)

@savitaashture
Copy link
Member Author

this looks good but we really need to take the opportunity to add unittests for this file (configmap)

Yes sure agree

Shall i do that as a separate PR

@chmouel
Copy link
Member

chmouel commented Mar 7, 2023

let's do this in this PR, what do you think?

@savitaashture
Copy link
Member Author

let's do this in this PR, what do you think?

Yes works for me

@chmouel chmouel merged commit 4b1da61 into openshift-pipelines:main Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants