Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github user collaborator check #1187

Conversation

pbrogan12
Copy link
Contributor

@pbrogan12 pbrogan12 commented Mar 9, 2023

Changes

If the number of collaborators is greater than the default page size of ListCollaborators request, it was possible for a pipeline not to run for a collaborator. Instead of paginating the request use IsCollaborator.

Submitter Checklist

  • β™½ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • πŸ“– If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • πŸ§ͺ 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • πŸ”Ž If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

If the number of collaborators was greater than the default page size, it was
possible for a pipeline not to run for a collaborator.
@chmouel
Copy link
Member

chmouel commented Mar 10, 2023

/retest

@chmouel
Copy link
Member

chmouel commented Mar 10, 2023

looks good thanks a lot!

cc @savitaashture

Copy link
Member

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot πŸ‘

/lgtm

@savitaashture savitaashture merged commit 619ce45 into openshift-pipelines:main Mar 10, 2023
@pbrogan12 pbrogan12 deleted the fix-github-collaborator-check branch March 10, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

3 participants