New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use internal url from hub instead of public rawurl #1256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used raw url which usually go to github, but that fail for private hubs with rawurl going to a private repos. let use the internal url instead so this would be succefull. https://issues.redhat.com/browse/SRVKP-3048 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Golang test coverage difference reportCoverage decreased by Package report
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used raw url which usually go to github, but that fail for private
hubs with rawurl going to a private repos.
let use the internal url instead so this would be succefull.
https://issues.redhat.com/browse/SRVKP-3048
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com