Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use internal url from hub instead of public rawurl #1256

Merged
merged 1 commit into from Apr 27, 2023

Conversation

chmouel
Copy link
Member

@chmouel chmouel commented Apr 27, 2023

We used raw url which usually go to github, but that fail for private
hubs with rawurl going to a private repos.

let use the internal url instead so this would be succefull.

https://issues.redhat.com/browse/SRVKP-3048

Signed-off-by: Chmouel Boudjnah chmouel@redhat.com

We used raw url which usually go to github, but that fail for private
hubs with rawurl going to a private repos.

let use the internal url instead so this would be succefull.

https://issues.redhat.com/browse/SRVKP-3048

Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
@pipelines-as-code
Copy link

Golang test coverage difference report

Coverage decreased by 0.02%. 🔔 Shame 🔔

Package report
package                                                                            before    after    delta
-------                                                                           -------  -------  -------
pkg/acl                                                                           100.00%  100.00%         
pkg/action                                                                         68.75%   68.75%         
pkg/adapter                                                                        72.41%   72.41%         
pkg/apis/features                                                                 100.00%  100.00%         
pkg/cli/info                                                                       88.23%   88.23%         
pkg/cli/prompt                                                                     55.38%   55.38%         
pkg/cli/status                                                                     95.23%   95.23%         
pkg/cli/webhook                                                                    49.40%   49.40%         
pkg/cmd/tknpac/bootstrap                                                            2.11%    2.11%         
pkg/cmd/tknpac/completion                                                          50.00%   50.00%         
pkg/cmd/tknpac/create                                                              44.14%   44.14%         
pkg/cmd/tknpac/describe                                                            46.31%   46.31%         
pkg/cmd/tknpac/generate                                                            62.20%   62.20%         
pkg/cmd/tknpac/info                                                                62.50%   62.50%         
pkg/cmd/tknpac/list                                                                46.47%   46.47%         
pkg/cmd/tknpac/resolve                                                             71.42%   71.42%         
pkg/cmd/tknpac/webhook                                                             52.47%   52.47%         
pkg/consoleui                                                                      82.60%   82.60%         
pkg/events                                                                         73.33%   73.33%         
pkg/formatting                                                                     98.71%   98.71%         
pkg/git                                                                            84.84%   84.84%         
pkg/hub                                                                            90.62%   90.00%   -0.62%
pkg/kubeinteraction                                                                52.50%   52.50%         
pkg/kubeinteraction/status                                                         77.27%   77.27%         
pkg/matcher                                                                        86.47%   86.47%         
pkg/params/clients                                                                 14.86%   14.86%         
pkg/params/settings                                                                79.48%   79.48%         
pkg/pipelineascode                                                                 64.95%   64.95%         
pkg/provider                                                                       76.19%   76.19%         
pkg/provider/bitbucketcloud                                                        87.09%   87.09%         
pkg/provider/bitbucketserver                                                       88.88%   88.88%         
pkg/provider/gitea                                                                 34.14%   34.14%         
pkg/provider/github                                                                82.05%   82.05%         
pkg/provider/github/app                                                            78.33%   78.33%         
pkg/provider/gitlab                                                                86.64%   86.64%         
pkg/random                                                                        100.00%  100.00%         
pkg/reconciler                                                                     42.19%   42.19%         
pkg/resolve                                                                        87.93%   87.93%         
pkg/secrets                                                                        92.85%   92.85%         
pkg/sort                                                                           51.20%   51.20%         
pkg/sync                                                                           91.13%   91.13%         
pkg/templates                                                                     100.00%  100.00%         
pkg/webhook                                                                        22.22%   22.22%         
                                                                          total:   65.28%   65.26%   -0.02%

@piyush-garg
Copy link
Member

/lgtm

@chmouel chmouel merged commit bcbd54c into openshift-pipelines:main Apr 27, 2023
3 checks passed
@chmouel chmouel deleted the use-raw-url branch April 27, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants