New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let user define pipeline provenance definition #1258
Let user define pipeline provenance definition #1258
Conversation
Golang test coverage difference reportCoverage decreased by Package report
|
259d6f7
to
cd9c07c
Compare
/retest |
### Reporting to a custom Dashboard/Console | ||
|
||
Alternatively, you have the ability to configure the links to go to your custom | ||
dashboard using the following settings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we require this doc change here in this PR π€ asking because doc change is related to custom console param
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i rephrase all the time the doc if i find a missphrase or misspell.. no need for new pr or commit...
9d0d634
to
0fe2d55
Compare
PR looks good to me π We can merge once CI is green |
By default on a `Push` or a `Pull Request`, Pipelines as Code will fetch the PipelineRun definition from the branch of where the event has been triggered. This behavior can be changed by setting the setting `pipelinerun_provenance`. The setting currently accept two values: - `source`: The default behavior, the PipelineRun definition will be fetched from the branch of where the event has been triggered. - `default_branch`: The PipelineRun definition will be fetched from the default branch of the repository as configured on the git platform. For example `main`, `master`, or `trunk`. Example: This configuration specifies a repository named my-repo with a URL of <https://github.com/my-org/my-repo>. It also sets the `pipelinerun_provenance` setting to `default_branch`, which means that the PipelineRun definition will be fetched from the default branch of the repository. ```yaml apiVersion: "pipelinesascode.tekton.dev/v1alpha1" kind: Repository metadata: name: my-repo spec: url: "https://github.com/owner/repo" settings: pipelinerun_provenance: "default_branch" ``` SRVKP: https://issues.redhat.com/browse/SRVKP-2896 Letting the user specify the provenance of the PipelineRun definition to default branch is another layer of security. It ensures that only the one who has the right to merge commit to the default branch can change the PipelineRun and have access to the infrastrucutre. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
8318215
to
85d7937
Compare
π π |
Let user define pipeline provenance definition
By default on a
Push
or aPull Request
, Pipelines as Code will fetch thePipelineRun definition from the branch of where the event has been triggered.
This behavior can be changed by setting the setting
pipelinerun_provenance
.The setting currently accept two values:
source
: The default behavior, the PipelineRun definition will be fetchedfrom the branch of where the event has been triggered.
default_branch
: The PipelineRun definition will be fetched from the defaultbranch of the repository as configured on the git platform. For example
main
,master
, ortrunk
.Example:
This configuration specifies a repository named my-repo with a URL of
https://github.com/my-org/my-repo. It also sets the
pipelinerun_provenance
setting to
default_branch
, which means that the PipelineRun definition will befetched from the default branch of the repository.
Letting the user specify the provenance of the PipelineRun definition to default
branch is another layer of security. It ensures that only the one who has the
right to merge commit to the default branch can change the PipelineRun and have
access to the infrastrucutre.
Signed-off-by: Chmouel Boudjnah chmouel@redhat.com
SRVKP: https://issues.redhat.com/browse/SRVKP-2896
Changes
Submitter Checklist
make test lint
before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI