Use displayName if set for showing task status

[chmouel]

The displayName field has been introduced since Tekton Pipeline 0.47.x, use this when showing the task breakdown status.

Screenshot, assuming a pipelineSpecs looking like this:

  pipelineSpec:
    tasks:
      - name: noop-task
        displayName: "A failure"
        taskSpec:
          steps:
            - name: noop-task
              image: registry.access.redhat.com/ubi9/ubi-micro
              script: |
                echo "hello from main"
                exit 1
      - name: noop-task2
        displayName: "A success"
        taskSpec:
          steps:
            - name: noop-task
              image: registry.access.redhat.com/ubi9/ubi-micro
              script: |
                exit 0
      - name: no-display-name
        taskSpec:
          steps:
            - name: noop-task
              image: registry.access.redhat.com/ubi9/ubi-micro
              script: |
                exit 0

It would show the displayName if set or fallback to just taskName otherwise:

Changes

Submitter Checklist

• 📝 A good commit message is important for other reviewers to understand the context of your change. Please refer to How to Write a Git Commit Message for more details how to write beautiful commit messages. We rather have the commit message in the PR body and the commit message instead of an external website.
• ♽ Run make test before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI. (or even better install pre-commit and do pre-commit install in the root of this repo).
• ✨ We heavily rely on linters to get our code clean and consistent, please ensure that you have run make lint before submitting a PR. The markdownlint error can get usually fixed by running make fix-markdownlint (make sure it's installed first)
• 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
• 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
• 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
• 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

[codecov]

Codecov Report

Patch coverage: 57.89% and project coverage change: +0.01% 🎉

Comparison is base (9170a22) 61.28% compared to head (bb48c6e) 61.30%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1413      +/-   ##
==========================================
+ Coverage   61.28%   61.30%   +0.01%     
==========================================
  Files         136      136              
  Lines       10064    10081      +17     
==========================================
+ Hits         6168     6180      +12     
- Misses       3398     3402       +4     
- Partials      498      499       +1     

Files Changed	Coverage Δ
pkg/reconciler/status.go	59.43% <0.00%> (-2.34%)	⬇️
pkg/kubeinteraction/status/task_status.go	65.71% <66.66%> (+0.14%)	⬆️
pkg/sort/task_status.go	80.43% <100.00%> (+1.86%)	⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sm43]

does it needs to be behind feature flag? or by default is fine?
by default is fine though by me, its just creates inconsistency when display name is not there

[chmouel]

seems to be by default ! (as i have it available) it otherwise fallback to name if not set

[savitaashture]

/lgtm

🎉

[savitaashture]

Verified PR so merging now