sync 'error-detection-simple-regexp' default value #1683
Conversation
jkandasa
changed the title
|
/test |
|
|
| ErrorLogSnippet bool `default:"true" json:"error-log-snippet"` | ||
| ErrorDetection bool `default:"true" json:"error-detection-from-container-logs"` | ||
| ErrorDetectionNumberOfLines int `default:"50" json:"error-detection-max-number-of-lines"` | ||
| ErrorDetectionSimpleRegexp string `default:"^(?P<filename>[^:]*):(?P<line>[0-9]+):(?P<column>[0-9]+)?([ ]*)?(?P<error>.*)" json:"error-detection-simple-regexp"` |
There was a problem hiding this comment.
@chmouel I see already you have updated the config map with ? on #1232
but not updated in https://github.com/openshift-pipelines/pipelines-as-code/blob/release-v0.27.0/pkg/params/settings/config.go#L62
There was a problem hiding this comment.
i see yeah, we need to figure out a way to have a CI job to sync or check the two because this becomes a pain
jkandasa
force-pushed
the
sync_error_detection_regexp
branch
from
9c3270b
to
7d67720
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
=======================================
Coverage 64.41% 64.41%
=======================================
Files 143 143
Lines 11091 11091
=======================================
Hits 7144 7144
Misses 3421 3421
Partials 526 526 ☔ View full report in Codecov by Sentry. |
|
Ready |
Signed-off-by: Jeeva Kandasamy <jkandasa@redhat.com>
jkandasa
force-pushed
the
sync_error_detection_regexp
branch
from
7d67720
to
ef987bb
Compare
jkandasa
changed the title
|
I am a bit confuse about this commit i'll need to spend more time to test it manually since we don't have e2e for this error reporting (since we can't see the checks output from an API) |
|
tested as working! |
Changes
error-detection-simple-regexpdefault value\nfromerror-detection-simple-regexponconfig/302-pac-configmap.yamlSubmitter Checklist
📝 Please ensure your commit message is clear and informative. For guidance on crafting effective commit messages, refer to the How to write a git commit message guide. We prefer the commit message to be included in the PR body itself rather than a link to an external website (ie: Jira ticket).
♽ Before submitting a PR, run make test lint to avoid unnecessary CI processing. For an even more efficient workflow, consider installing pre-commit and running pre-commit install in the root of this repository.
✨ We use linters to maintain clean and consistent code. Please ensure you've run make lint before submitting a PR. Some linters offer a --fix mode, which can be executed with the command make fix-linters (ensure markdownlint and golangci-lint tools are installed first).
📖 If you're introducing a user-facing feature or changing existing behavior, please ensure it's properly documented.
🧪 While 100% coverage isn't a requirement, we encourage unit tests for any code changes where possible.
🎁 If feasible, please check if an end-to-end test can be added. See README for more details.
🔎 If there's any flakiness in the CI tests, don't necessarily ignore it. It's better to address the issue before merging, or provide a valid reason to bypass it if fixing isn't possible (e.g., token rate limitations).