Allow multiple pipelinerun for the same event #589
Conversation
chmouel
force-pushed
the
multiplex
branch
2 times, most recently
from
cad521b
to
dfc6238
Compare
| } | ||
|
|
||
| if annotationRepo.Spec.URL != "" { | ||
| repo = annotationRepo | ||
| // TODO: We need to figure out secretCreation, it's buggy normally without multiplexing ie:bug #543 |
There was a problem hiding this comment.
what if we create one secret for each pipeline?
anyway the secret is short lived till the life of pr
There was a problem hiding this comment.
till we find a way to enable this again what would be side effect of this change?
multiple pipeline from private repo would fail right?
There was a problem hiding this comment.
let us work on this in a following PR, i may have a nice solution,
|
the e2e test error are legit, just finishing to fix it. |
| @@ -94,7 +94,7 @@ spec: | |||
| }, | |||
| }, | |||
| { | |||
| name: "test-annotations-inside-repo", | |||
| name: "test-annotations-inside-Repo", | |||
There was a problem hiding this comment.
was this a find and replace repo -> Repo
change ? 😄
There was a problem hiding this comment.
just un Alt-c too much :D
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
|
also how this is suppose to work with webhooks ? |
the same as before ? what do you mean by one message? (there was a bug in e2e with webhooks just before which i just fixed) |
we now gets all the matched condition from the matcher in the same struct we did a bunch of refactoring to break out .Run which got moved to its own Make event able to process multiple pipelineruns We run a goroutine in a workgroups which we wait for. This will be run in the main goroutine which started from the sinker. We disable secret auto creation for now when running multiples, it has many issues we need to fix regardless. We retries if we can't update the RepoStatus until we are able to do it. Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
while using webhook we post a comment with breakdown |
|
yeah correct, or i believe it will, i have just enabled multiple prs e2e test for gitlab so will see how it goes 🙃 |
|
|
|
Gitlab is fine now and looks like this :
I am not sure about bitbucket yet 😅 gitlab api is a bit awkward since you can't upload multiple files at the same time, will see if bitbucket is the same.. |
Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
|
Bitbucket is okay now :
|
|
may be we should add which pipeline name in comment ? |
chmouel
changed the title
Co-authored-by: Shivam Mukhade <smukhade@redhat.com>
Changes
Allow multiple pipelinerun on the same event
Fixes #528
A bunch of of refactoring to break out .Run which got moved to its own.
We have a
sync.Mapof checkRunIds to track the checkRuns to which pipelineRun, we use github api "external_id" field for that .We run a goroutine in a workgroups waiting for all the pr to run This wait that all of them finishes before exiting to the adapter goroutine.
We retries if we can't update the RepoStatus until we are able to do it.
TODO (before merge):
TODO (post):
/test prnamesupportScreenshot:
Submitter Checklist
make test lintbefore submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI