Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds setup bitbucket-cloud-webhook command #731

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

sm43
Copy link
Contributor

@sm43 sm43 commented Jun 20, 2022

 > ~/go/src/github.com/openshift-pipelines/bitc-pac (sm) > tkn pac setup bitbucket-cloud-webhook
✓ Setting up Bitbucket Webhook for Repository https://bitbucket.org/smukhade/pac-e2e-test
? Please enter your bitbucket cloud username:  smukhade
ℹ ️You now need to create a Bitbucket Cloud app password, please checkout the docs at https://is.gd/fqMHiJ for the required permissions
? Please enter the Bitbucket Cloud app password:  ********************
👀 I have detected a controller url: https://smee.io/RfJSeRjNXRA25A
? Do you want me to use it? Yes
✓ Webhook has been created on repository smukhade/pac-e2e-test
? Would you like me to create the Repository CR for your git repository? Yes
? Please enter the namespace where the pipeline should run (default: pac-e2e-test-pipelines): 
! Namespace pac-e2e-test-pipelines is not found
? Would you like me to create the namespace pac-e2e-test-pipelines? Yes
✓ Repository smukhade-pac-e2e-test has been created in pac-e2e-test-pipelines namespace
🔑 Webhook Secret smukhade-pac-e2e-test has been created in the pac-e2e-test-pipelines namespace.
🔑 Repository CR smukhade-pac-e2e-test has been updated with webhook secret in the pac-e2e-test-pipelines namespace

Closes #624
Signed-off-by: Shivam Mukhade smukhade@redhat.com

Changes

Submitter Checklist

  • ♽ Run make test lint before submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI
  • 📖 If you are adding a user facing feature or make a change of the behavior, please verify that you have documented it
  • 🧪 100% coverage is not a target but most of the time we would rather have a unit test if you make a code change.
  • 🎁 If that's something that is possible to do please ensure to check if we can add a e2e test.
  • 🔎 If there is a flakiness in the CI tests then don't necessary ignore it, better get the flakyness fixed before merging or if that's not possible there is a good reason to bypass it. (token rate limitation may be a good reason to skip).

@sm43 sm43 requested a review from chmouel June 20, 2022 06:46
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2022

Codecov Report

Merging #731 (55e23fc) into main (e82e6b5) will decrease coverage by 0.16%.
The diff coverage is 59.55%.

@@            Coverage Diff             @@
##             main     #731      +/-   ##
==========================================
- Coverage   65.34%   65.17%   -0.17%     
==========================================
  Files          69       70       +1     
  Lines        4103     4201      +98     
==========================================
+ Hits         2681     2738      +57     
- Misses       1160     1192      +32     
- Partials      262      271       +9     
Impacted Files Coverage Δ
pkg/cli/webhook/secret.go 0.00% <0.00%> (ø)
pkg/cli/webhook/webhook.go 0.00% <0.00%> (ø)
pkg/cli/webhook/bitbucket_cloud.go 62.35% <62.35%> (ø)
pkg/webhook/controller.go 0.00% <0.00%> (ø)
pkg/consoleui/tektondashboard.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e82e6b5...55e23fc. Read the comment docs.

Copy link
Member

@chmouel chmouel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good, feel free to address the minor suggestions/comment and/or merge this directly

@chmouel
Copy link
Member

chmouel commented Jun 22, 2022

need to update token for e2e

Signed-off-by: Shivam Mukhade <smukhade@redhat.com>
@chmouel chmouel merged commit 0260b8a into openshift-pipelines:main Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Configure Bitbucket Cloud using CLI
3 participants