Allow filter pipelinerun by event title #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chmouel
changed the title
chmouel
force-pushed
the
issue-768-filter-pull-request-events-by-title-using-advanced-ex
branch
2 times, most recently
from
07ac744
to
a90e2dc
Compare
Codecov Report
@@ Coverage Diff @@
## main #769 +/- ##
==========================================
+ Coverage 65.25% 65.88% +0.63%
==========================================
Files 75 75
Lines 4533 4494 -39
==========================================
+ Hits 2958 2961 +3
+ Misses 1295 1252 -43
- Partials 280 281 +1
Continue to review full report at Codecov.
|
pkg/matcher/cel.go
Outdated
Comment on lines
82
to
97
| func (t celPac) pathChanged(vals ref.Val) ref.Val { | ||
| var match types.Bool | ||
| fileList, err := t.vcx.GetFiles(t.ctx, t.event) | ||
| if err != nil { | ||
| return types.Bool(false) | ||
| } | ||
| for i := range fileList { | ||
| if v, ok := vals.Value().(string); ok { | ||
| g := glob.MustCompile(v) | ||
| if g.Match(fileList[i]) { | ||
| return types.Bool(true) | ||
| } | ||
| } | ||
| match = types.Bool(false) | ||
| } | ||
|
|
5 tasks
chmouel
force-pushed
the
issue-768-filter-pull-request-events-by-title-using-advanced-ex
branch
from
d0527b5
to
55e8712
Compare
|
/hold |
This supports push and pull_request (pull request title and sha event) Closes openshift-pipelines#768 Signed-off-by: Chmouel Boudjnah <chmouel@redhat.com>
some spagetthi code to make test annotation_matcher on github and gitlab
chmouel
force-pushed
the
issue-768-filter-pull-request-events-by-title-using-advanced-ex
branch
from
12c21ee
to
78488bd
Compare
|
e2e tests should work now, aside of the annoying token expiration limit |
chmouel
deleted the
issue-768-filter-pull-request-events-by-title-using-advanced-ex
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let filter events by title, using CEL
add event_title which support push and pull request
Fixes #768
need to go after #751
Changes
Submitter Checklist
make test lintbefore submitting a PR (ie: with pre-commit, no need to waste CPU cycle on CI