TKNECO-20: Import s2i-dotnet Task #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneesh-M-Bhat
force-pushed
the
s2i-dotnet
branch
from
2e8df75
to
0c77faf
Compare
Aneesh-M-Bhat
force-pushed
the
s2i-dotnet
branch
from
0c77faf
to
03419de
Compare
|
Updated the PR, now we are using a parameter in the Makefile as well as the task, for the tests we use the parameter E2E_S2I_PARAMS_ENV_VARS in the Makefile, the task has also been updated appropriately to make use of ENV_VARS param, which will then be used to make an environment file, this will be used as the environment file for the s2i build command |
This was referenced Aug 9, 2023
Closed
Aneesh-M-Bhat
force-pushed
the
s2i-dotnet
branch
from
03419de
to
5d7837a
Compare
otaviof
suggested changes
Aug 23, 2023
Aneesh-M-Bhat
force-pushed
the
s2i-dotnet
branch
from
5d7837a
to
b642d07
Compare
otaviof
suggested changes
Aug 24, 2023
Aneesh-M-Bhat
force-pushed
the
s2i-dotnet
branch
from
b642d07
to
97016ea
Compare
|
Fixes #19. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://issues.redhat.com/browse/TKNECO-20
Progress:
Currently, I have updated the script itself for adding .s2i/environment file to the source code which will allow us to add the required DOTNET_STARTUP_PROJECT env variable, that helps with showing .csproj file to be published for .NET
PTAL, we could add a volume mount for .s2i/environment or could copy some file given by user to the said path or keep the same implementation, need feedback on this matter.
To run the test, use
make test-e2e-s2i-dotnet E2E_S2I_PARAMS_REVISION=main