Added dockerconfig workspace and corrected regex expression for all 3 tasks. #80
Conversation
values.yaml
Outdated
| @@ -4,8 +4,8 @@ images: | |||
| bash: registry.access.redhat.com/ubi8-minimal:8.9 | |||
| skopeo: registry.access.redhat.com/ubi8/skopeo:8.9 | |||
| buildah: registry.access.redhat.com/ubi8/buildah:8.9 | |||
| s2i: registry.access.redhat.com/source-to-image/source-to-image-rhel8:v1.3.9-6 | |||
|
|
|||
| s2i: registry.redhat.io/source-to-image/source-to-image-rhel8:v1.3.9-6 | |||
There was a problem hiding this comment.
Nope the registry.access.redhat.com doesn't work @vdemeester .
There was a problem hiding this comment.
On CI it works / worked, otherwise we wouldn't had a green CI 😝
There was a problem hiding this comment.
I agree with @vdemeester both will work
@Senjuti256 if you are facing any issue with image pull locally try to change locally and test and i think we should n't change here untill CI works fine
There was a problem hiding this comment.
@vdemeester @savitaashture made the required changes.
Senjuti256
force-pushed
the
dockerconfigW
branch
from
e726bfe
to
3287362
Compare
|
/retest |
|
/retest-required |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Senjuti256, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test osp-113-ocp-414-e2e |
openshift-merge-bot
bot
merged commit f26b1e8
into
openshift-pipelines:main
Added the optional dockerconfig workspace to the S2I task to provide flexibility to the customers to provide their dockerfile and also to make our task at par with the S2I clustertasks.
Signed off by:- @Senjuti256 sde@redhat.com