Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update params and readme for skopeo #84

Merged

Conversation

savitaashture
Copy link
Member

No description provided.

Copy link
Contributor

@Senjuti256 Senjuti256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 2 lines need to be updated. @savitaashture

Copy link
Contributor

@Senjuti256 Senjuti256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"params.SOURCE" "params.DESTINATION"

These 2 lines (line 68 and 69 ) in task-skopeo-copy.yaml needs to be updated to
"params.SOURCE_IMAGE_URL" "params.DESTINATION_IMAGE_URL"

@savitaashture
Copy link
Member Author

"params.SOURCE" "params.DESTINATION"

These 2 lines (line 68 and 69 ) in task-skopeo-copy.yaml needs to be updated to "params.SOURCE_IMAGE_URL" "params.DESTINATION_IMAGE_URL"

Done 👍

Copy link
Contributor

@Senjuti256 Senjuti256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Apr 29, 2024
Copy link

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: savitaashture, Senjuti256

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 26cef3b into openshift-pipelines:main Apr 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants