Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests are all good now & release changes #26

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

Aneesh-M-Bhat
Copy link
Contributor

  • had some issues with the tests when running previously, because . was redundant in the regex & sometimes would match folders like .bin, .git etc, so resolved that.
  • also there was an issue with git-clone task not being asserted successfully because the assert would not get the values in time, so added a delay.
  • finally, few make file targets for individual testing & changes to release script to include all tasks.

@savitaashture
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot removed the lgtm label Mar 21, 2024
@openshift-ci openshift-ci bot added the lgtm label Mar 21, 2024
@savitaashture
Copy link
Member

/lgtm

Copy link

openshift-ci bot commented Mar 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Aneesh-M-Bhat, savitaashture
Once this PR has been reviewed and has the lgtm label, please assign concaf for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@savitaashture savitaashture merged commit 99ad7cd into openshift-pipelines:main Mar 21, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants