Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

benchmarking: make the execution easier to reproduce #301

Merged
merged 3 commits into from
Dec 13, 2021
Merged

benchmarking: make the execution easier to reproduce #301

merged 3 commits into from
Dec 13, 2021

Conversation

kpouget
Copy link
Collaborator

@kpouget kpouget commented Dec 9, 2021 •
edited
Loading

This PR stores the YAML definition of the resources used to 1) download the COCO dataset and 2) trigger the benchmark
into dedicate files, so that it's easier for anyone to re-execute these steps outside of the CI, and without ci-artifacts toolbox.

See the files 00x in these two directories:

@kpouget
Copy link
Collaborator Author

kpouget commented Dec 9, 2021

/test test-commit

@kpouget
Copy link
Collaborator Author

kpouget commented Dec 10, 2021

/test test-commit

@kpouget
Copy link
Collaborator Author

kpouget commented Dec 10, 2021 via email

@kpouget
benchmarking_run_nvidiadl_ssd: make the execution easier to reproduce
38f5ca5 
Run the test twice, just to be sure reexecution is not broken:
@kpouget
testing: recipes/run_cocodataset_nvidiadl_ssd: allow running the benc…
d8d2143 
…hmark twice

Run the test twice, just to be sure reexecution is not broken:

test-path: recipes run_cocodataset_nvidiadl_ssd download_twice benchmark_twice
@kpouget
Copy link
Collaborator Author

kpouget commented Dec 10, 2021

test results look as expected, good for merging

(I only had to add a -oyaml, no need to retrigger the test for that)

/approve
/override ci/prow/gpu-operator-e2e

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

@kpouget: Overrode contexts on behalf of kpouget: ci/prow/gpu-operator-e2e

In response to this:

test results look as expected, good for merging

(I only had to add a -oyaml, no need to retrigger the test for that)

/approve
/override ci/prow/gpu-operator-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 10, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 10, 2021
@kpouget kpouget changed the title benchmarking_deploy_coco_dataset: make the execution easier to reproduce benchmarking: make the execution easier to reproduce Dec 10, 2021
@dagrayvid
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 13, 2021
@openshift-merge-robot openshift-merge-robot merged commit 7872740 into openshift-psap:master Dec 13, 2021
@kpouget kpouget mentioned this pull request Dec 17, 2021
Closed
@kpouget kpouget deleted the coco branch January 6, 2022 10:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez

@dagrayvid dagrayvid Awaiting requested review from dagrayvid

Assignees

@dagrayvid dagrayvid

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kpouget @dagrayvid @openshift-merge-robot