Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGENT-565: make the pull check mandatory, the other checks as non blocking #14

Merged

Conversation

andfasano
Copy link
Contributor

Now only the pull check can interrupt the timeout dialog if failing.
All the other checks are still being executed in parallel, but their eventual failure will not prevent the agent-tui to automatically close.
Removed also the previous skipping logic.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 1, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2023

@andfasano: This pull request references AGENT-565 which is a valid jira issue.

In response to this:

Now only the pull check can interrupt the timeout dialog if failing.
All the other checks are still being executed in parallel, but their eventual failure will not prevent the agent-tui to automatically close.
Removed also the previous skipping logic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from celebdor and zaneb March 1, 2023 20:41
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 1, 2023

@andfasano: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@zaneb
Copy link
Member

zaneb commented Mar 1, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2023
@openshift-merge-robot openshift-merge-robot merged commit 99aefff into openshift:main Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants