New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STOR-1714: Release leadership on SIGTERM #83
STOR-1714: Release leadership on SIGTERM #83
Conversation
@jsafrane: This pull request references STOR-1714 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jsafrane: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
/label docs-approved |
@jsafrane: This pull request references STOR-1714 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
f510004
into
openshift:master
[ART PR BUILD NOTIFIER] This PR has been included in build ose-alibaba-disk-csi-driver-operator-container-v4.16.0-202401081411.p0.gf510004.assembly.stream for distgit ose-alibaba-disk-csi-driver-operator. |
When
RunOperator()
returns no error, library-go waits for leader election goroutine to release the leadership before exiting.An error returned from
RunOperator()
takes a shortcut and leads to much fasterexit(1)
, not giving the election goroutine time to release its lease. A subsequent operator pod needs to wait for the old lease to expire, which slows down cluster upgrade and any development / debugging that needs the operator restarted.cc @openshift/storage