Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove organization from the image field in the apb.yml #288

Closed
cfchase opened this issue Jul 19, 2017 · 2 comments
Closed

Remove organization from the image field in the apb.yml #288

cfchase opened this issue Jul 19, 2017 · 2 comments
Assignees

Comments

@cfchase
Copy link
Contributor

cfchase commented Jul 19, 2017

Current behavior:
#apb.yml
image: ansibleplaybookbundle/my-apb
This means that the broker downloads the spec from an organization, but may actually download the image from an entirely different organization, leading to confusion.

Proposed:
#apb.yml
image: my-apb
ASB will assume the apb image is in the same repository and org where the spec was found.

Will require changes in:

  • ansible-service-broker - no longer use the org in a spec and use where it's hosted instead.
  • ansible-playbook-bundle - remove org from apb-init and build

Reasoning:

  1. Stable - Allow a user to download an image, retag it, and then push it to a different org for either testing or production use without modifying and rebuilding. We want to test the built image as is without modifying it and introducing changes.
  2. Less confusion - since a user may forget to change the org, they'd be testing the original image on a different org and may be confused why changes aren't reflected.
  3. Reusable - we would want users and developers to be sharing images without forcing them to rebuild the image with changes before pushing to their own organization for use.
@jwmatthews
Copy link
Member

@cfchase
Copy link
Contributor Author

cfchase commented Jul 19, 2017

@djzager djzager self-assigned this Aug 16, 2017
djzager added a commit to djzager/ansible-service-broker that referenced this issue Sep 14, 2017
The purpose of this change is to make it so that the full path to each
image is used when executing APBs instead of relying on what is stated
in the APB yaml.

- Update the Spec to make Image optional (for when we remove it from APB
  yaml)
- Update the registry adapters to store the full path to the image when
  unmarshalling the APB yaml -> APB spec before we store it into `etcd`
- Update the broker to have simpler format for `FQName`

Implements openshift#431
Fixes openshift#288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants