Bug 1498954 - Broker in developer mode must support apb push

[djzager]

Testing for this PR

Just used the apb tool to push an image to the broker and looked at how the image was stored by looking at the logs of the broker.

Before Change:

[2017-10-05T14:22:55.126Z] [DEBUG] handler::apbAddSpec
[2017-10-05T14:22:55.126Z] [DEBUG] Successfully decoded pushed spec:
[2017-10-05T14:22:55.126Z] [DEBUG] version: 1.0
name: hello-world-apb
description: deploys hello-world web application
bindable: False
async: optional
metadata:
  displayName: Hello World (APB)
  longDescription: A sample APB which deploys a containerized Hello World web application
  dependencies: ['docker.io/ansibleplaybookbundle/hello-world:latest']
  providerDisplayName: "Red Hat, Inc."
plans:
  - name: default
    description: A sample APB which deploys Hello World
    free: True
    metadata:
      displayName: Default
      longDescription: This plan deploys a Python web application displaying Hello World
      cost: $0.00
    parameters: []
 
[2017-10-05T14:22:55.127Z] [DEBUG] Unmarshalled into apb.Spec:
[2017-10-05T14:22:55.127Z] [DEBUG] {ID: Version:1.0 FQName:hello-world-apb Image: Tags:[] Bindable:false Description:deploys hello-world web application Metadata:map[displayName:Hello World (APB) longDescription:A sample APB which deploys a containerized Hello World web application dependencies:[docker.io/ansibleplaybookbundle/hello-world:latest] providerDisplayName:Red Hat, Inc.] Async:optional Plans:[{Name:default Description:A sample APB which deploys Hello World Metadata:map[displayName:Default longDescription:This plan deploys a Python web application displaying Hello World cost:$0.00] Free:true Bindable:false Parameters:[]}]}

After Change:

[2017-10-05T15:23:16.817Z] [DEBUG] handler::apbAddSpec
[2017-10-05T15:23:16.817Z] [DEBUG] Successfully decoded pushed spec:
[2017-10-05T15:23:16.817Z] [DEBUG] version: 1.0
name: hello-world-apb
description: deploys hello-world web application
bindable: False
async: optional
metadata:
  displayName: Hello World (APB)
  longDescription: A sample APB which deploys a containerized Hello World web application
  dependencies: ['docker.io/ansibleplaybookbundle/hello-world:latest']
  providerDisplayName: "Red Hat, Inc."
plans:
  - name: default
    description: A sample APB which deploys Hello World
    free: True
    metadata:
      displayName: Default
      longDescription: This plan deploys a Python web application displaying Hello World
      cost: $0.00
    parameters: []
 
[2017-10-05T15:23:16.817Z] [DEBUG] Unmarshalled into apb.Spec:
[2017-10-05T15:23:16.818Z] [DEBUG] {ID: Version:1.0 FQName:hello-world-apb Image:hello-world-apb Tags:[] Bindable:false Description:deploys hello-world web application Metadata:map[displayName:Hello World (APB) longDescription:A sample APB which deploys a containerized Hello World web application dependencies:[docker.io/ansibleplaybookbundle/hello-world:latest] providerDisplayName:Red Hat, Inc.] Async:optional Plans:[{Name:default Description:A sample APB which deploys Hello World Metadata:map[displayName:Default longDescription:This plan deploys a Python web application displaying Hello World cost:$0.00] Free:true Bindable:false Parameters:[]}]}

[djzager]

@karmab If you were able to test this change for your purposes, I would appreciate it.

[dymurray]

LGTM

[jmrodri]

Feels weird to put this in the handler. I would put it in AddSpec of broker.go.

[dymurray]

+1 putting it in AddSpec makes more sense because that's what gets called when you push to the dev endpoint.

[karmab]

@djzager thanks for the change, do i have to build everything in order to test this one?

[karmab]

i tested the PR and didnt get the error

I agree with Jesus' comment