Bug 1502044 - deprovision fixes #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
Testing:
ResultsBefore fix (broker): After fix (broker): After fix (service-catalog): |
| executionContext, err := ExecuteApb( | ||
| "deprovision", clusterConfig, instance.Spec, | ||
| instance.Context, instance.Parameters, log, | ||
| ) | ||
| defer sm.DestroyApbSandbox(executionContext, clusterConfig) |
There was a problem hiding this comment.
How do we handle the error, if DestroyApbSandbox has an error? We can make sure that the log of the error happens in the Destroy function, but maybe make it return nothing to make it more clear how to use it?
There was a problem hiding this comment.
Unless you want to wrap it in another call just for this area.
There was a problem hiding this comment.
defer func(context ExecutionContenxt config ClusterConfig) {
err := sm.DestoryApbSandbox(execution, config)
if err != nil {
log.Errorf("Error occurred destroying sandbox during deprovision: \n%s", err)
}
}(executionContext, clusterConfig)
Would this suffice? Should we be taking any additional action in the presence of an error here aside from loudly logging?
There was a problem hiding this comment.
I updated to the DestroyApbSandbox to simply log loudly when it fails and return nothing. Let me know if I should go with this method instead.
jmrodri
approved these changes
Oct 16, 2017
| executionContext, err := ExecuteApb( | ||
| "deprovision", clusterConfig, instance.Spec, | ||
| instance.Context, instance.Parameters, log, | ||
| ) | ||
| defer sm.DestroyApbSandbox(executionContext, clusterConfig) |
There was a problem hiding this comment.
Unless you want to wrap it in another call just for this area.
djzager
force-pushed
the
bz1502044-deprovision
branch
from
465dd5f
to
a96804a
Compare
openshift-ci-robot
added
size/L
|
Since I added changes for bind/unbind, I'm going to manually test to verify those are still working as expected. Done. ✅ |
djzager
force-pushed
the
bz1502044-deprovision
branch
from
a96804a
to
e85fe13
Compare
shawn-hurley
approved these changes
Oct 17, 2017
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
* Bug 1502044 - return 202 on async deprovision * Defer sandbox teardown to prevent leaks * Destroy APB Sandbox should not return anything * Improve apb error logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
This PR is meant to address a few errors with respect to service catalog requests to provision/deprovision.