when building the broker for image always build for linux OS. #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
rthallisey
approved these changes
Oct 31, 2017
jmrodri
reviewed
Oct 31, 2017
| build-image: broker ## Build a docker image with the broker binary | ||
| cp broker build/broker | ||
| build-image: ## Build a docker image with the broker binary | ||
| env GOOS=linux go build -i -ldflags="-s -s" -o ${BUILD_DIR}/broker ./cmd/broker |
There was a problem hiding this comment.
The only downside to this is that it will build everytime, where the previous version only did it if the broker was out of date. One could argue though you wouldn't be calling build-image if you didn't cause a change
jmrodri
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Always build the broker binary for OS of Linux and output to the build directory
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #521