Bug 1508724 - Improve logging when using an incorrect tag #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
shawn-hurley
requested changes
Nov 6, 2017
pkg/registries/adapters/adapter.go
Outdated
| if err != nil { | ||
| log.Errorf("Image '%s' may not exist in registry: %s", image, debug) |
There was a problem hiding this comment.
I think using the registry name here, rather then the response body, might make more sense and then you can remove the copy of the byte array?
There was a problem hiding this comment.
This error check really is catching two error scenarios: A json decoding error and a request error. I'm going to change this to two different checks by looking for a bad http status code.
I thought about that adding in the registry, but it's embedded in the image variable: http://<registry>/<image>/<tag>.
If a registry is missing the image with the specified tag, the logging does not indicate what the error could be. Instead, make a suggestion about the error and print out the request body.
|
The poor logging was identified in: https://bugzilla.redhat.com/show_bug.cgi?id=1508724 |
|
I just re-use that BZ, I think this is something worth merging IMO |
rthallisey
changed the title
shawn-hurley
approved these changes
Nov 6, 2017
shawn-hurley
changed the title
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
If a registry is missing the image with the specified tag, the logging does not indicate what the error could be. Instead, make a suggestion about the error and print out the request body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
If you set an incorrect tag for your images in the broker config, the logging
does not indicate what the error is. Instead, make a suggestion
about the error and print out the request body.
Changes proposed in this pull request