Bug 1507111 - Do not force image tag to be IP + Port #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/S
shawn-hurley
approved these changes
Nov 7, 2017
| r.Config.Namespaces = append(r.Config.Namespaces, "openshift") | ||
| } | ||
| spec.Image = image.Name | ||
| namespace := strings.Split(image.Name, "/")[1] |
There was a problem hiding this comment.
I don't like blindly accessing index of an array
openshift-ci-robot
added
size/M
shawn-hurley
requested changes
Nov 7, 2017
| ns_list := strings.Split(image.Name, "/") | ||
| var namespace string | ||
| if len(ns_list) == 0 { | ||
| r.Log.Errorf("Image [%v] is not in the proper format. Erroring.") |
There was a problem hiding this comment.
missing image name in print statement.
shawn-hurley
approved these changes
Nov 7, 2017
djzager
reviewed
Nov 7, 2017
| } | ||
| } | ||
| if strings.HasPrefix(image.Name, registryIP) == false { | ||
| r.Log.Debugf("Image does not have a registry IP as prefix. This might cause problems but not erroring out.") |
There was a problem hiding this comment.
@djzager Because if you look a few lines below it is possible that S2I images will not have any registry prefix at all. I'm indifferent to which type of logging statement it is but with 10 S2I images that would output 10 warning statements in the logs for something that is expected behavior.
Feels weird to warn the user over expected behavior.
There was a problem hiding this comment.
I figured there was a reason. In this case, the text of the message is the warning. Works for me.
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
* Bug 1507111 - Do not force image tag to be IP + Port * Better warning statement * Better error handling for bad image names * Forgot print statement * Linting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes default behavior of local registry adapter to not error out if APB name does not start with IP+port. This was erroring out when a user's image was being tagged with the svc name instead.
Changes proposed in this pull request
openshiftif not set