Remove WorkMsg interface to avoid unneeded marshalling and unmarshalling #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…halling. Add missing error checks in subscribers
openshift-ci-robot
added
the
size/L
|
Changes Unknown when pulling d19a6cc on maleck13:remove-wrkmsg-interface into ** on openshift:master**. |
shawn-hurley
approved these changes
Jan 2, 2018
| Method: apb.JobMethodDeprovision, | ||
| }) | ||
| }); err != nil { | ||
| log.Errorf("failed to set state after deprovision %#v", err) |
| var extCreds *apb.ExtractedCredentials | ||
| metrics.ProvisionJobFinished() | ||
|
|
||
| log.Debug("Processed provision message from buffer") | ||
| // HACK: this seems like a hack, there's probably a better way to | ||
| // get the data sent through instead of a string | ||
| json.Unmarshal([]byte(msg.Render()), &pmsg) |
dymurray
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Removes the WorkMsg interface as it only seems to be used to marshal msgs into strings and then the subscribers unmarshal back again. Now that we only have one JobMsg type, this seems unnecessary. This PR also adds missing err checks within the subscribers.
Changes proposed in this pull request