Bug 1526887 - Handle case when whitelist/blacklist set to "" #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
shawn-hurley
added
bug
needs-review
and removed
size/M
|
Changes Unknown when pulling 607d155 on shawn-hurley:bug-1526887 into ** on openshift:master**. |
openshift-ci-robot
added
the
size/M
|
Changes Unknown when pulling 56be204 on shawn-hurley:bug-1526887 into ** on openshift:master**. |
rthallisey
reviewed
Jan 5, 2018
pkg/registries/filter.go
Outdated
| @@ -62,6 +61,10 @@ func compileRegexp(regexStrs []string) ([]*regexp.Regexp, []failedRegexp) { | |||
| failedRegexps := []failedRegexp{} | |||
|
|
|||
| for _, str := range regexStrs { | |||
| if str == "" { | |||
| log.Debugf("ignoring empty string that was set as regex string") | |||
There was a problem hiding this comment.
How about: "Ignoring empty whitelist or blacklist regex."
rthallisey
approved these changes
Jan 5, 2018
|
Changes Unknown when pulling 416df5c on shawn-hurley:bug-1526887 into ** on openshift:master**. |
jianzhangbjz
pushed a commit
to jianzhangbjz/ansible-service-broker
that referenced
this pull request
May 17, 2018
…ft#609) * Bug 1526887 - Handle whitelist set to "" * removing bad log, because we are updating this file. * addressing PR comments around log wording.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Handles case when the yaml looks like
Changes proposed in this pull request
""Which issue this PR fixes (This will close that issue when PR gets merged)
Bug 1526887