Bug 1535182 - adding ability to retrieve an array of sub configs #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixing registry unique name regression. * Adding ability to get an array of sub configs. * Handling the case that final object is an array will return an array now. * if not the final key, will still attempt to look into array based on name then type.
shawn-hurley
added
bug
needs-review
3.9 | release-1.1
openshift-ci-robot
added
the
size/L
|
Changes Unknown when pulling da5a439 on shawn-hurley:bug-1535182 into ** on openshift:master**. |
jmrodri
approved these changes
Jan 18, 2018
| } | ||
| names[registry.RegistryName()] = true | ||
| } | ||
| } |
There was a problem hiding this comment.
Took me a while to get this, but yep it makes sense :)
There was a problem hiding this comment.
A Set is too high level for go. Maps are much better. /s
eriknelson
approved these changes
Jan 18, 2018
| @@ -449,3 +450,13 @@ func convertAPIRbacToK8SRbac(apiRole *apirbac.ClusterRole) *rbac.ClusterRole { | |||
| Rules: rules, | |||
| } | |||
| } | |||
|
|
|||
| func validateRegistryNames(registrys []registries.Registry) { | |||
There was a problem hiding this comment.
NIT: registrys -> registries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Adds ability for the config package to handle an array of elements
Changes proposed in this pull request
now.
the name then type.
Does this PR depend on another PR (Use this to track when PRs should be merged)
depends-on
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #644