Remove platform version header check comment #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
eriknelson
force-pushed
the
rm-handler-header-comment
branch
from
3134e1d
to
3889924
Compare
openshift-ci-robot
added
size/XS
|
Changes Unknown when pulling 3889924 on eriknelson:rm-handler-header-comment into ** on openshift:master**. |
|
Changes Unknown when pulling 3889924 on eriknelson:rm-handler-header-comment into ** on openshift:master**. |
rthallisey
approved these changes
Jan 19, 2018
jmrodri
suggested changes
Jan 19, 2018
There was a problem hiding this comment.
Failed LINT check
=================================
Lint
=================================
pkg/apb/types.go:318:2: struct field HttpProxy should be HTTPProxy
pkg/apb/types.go:319:2: struct field HttpsProxy should be HTTPSProxy
Found 2 lint suggestions; failing.
Makefile:27: recipe for target 'lint' failed
make: *** [lint] Error 1
The command "./scripts/travis.sh lint" exited with 2.
|
Rebase so it picks up the linter fixes |
eriknelson
force-pushed
the
rm-handler-header-comment
branch
from
3889924
to
022c9f6
Compare
|
Changes Unknown when pulling 022c9f6 on eriknelson:rm-handler-header-comment into ** on openshift:master**. |
|
@jmrodri rebased |
|
Merging without a bug since it removes a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
PR does nothing but remove a very old header check that has been commented out. Background on this is when we inherited our original http server from the template broker, it was checking for the presence of the
X-Broker-API-Version, which MUST be sent by the platform to brokers. The broker has no obligation with regard to this header; it's there in case brokers rely on features that may not be present in the platform they're currently talking to. IIRC, I created this issue because at the time, the catalog was not sending the header.I'm removing the comment (and want to close the issue) because I don't see an immediate need for us to re-introduce the check, especially considering we're often a project that is validating proposed features to the spec that do not yet exist in OSB master. The issue should be reopened, or a new issue filed if we find a need to cooperate with platforms that are not the k8s service catalog (could forsee this as we start to talk about the BrokerSDK).
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #34