Bug 1536629 - Send job msg immediately as job starts. To set initial JobState #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
|
Changes Unknown when pulling 5f8903d on maleck13:504-remove-need-for-setting-state-broker into ** on openshift:master**. |
|
@rthallisey yeah I think that makes sense. It is a small and distinct piece of work so can prob be merged faster then rebased onto the larger PR |
maleck13
force-pushed
the
504-remove-need-for-setting-state-broker
branch
from
38c0364
to
7b3035c
Compare
rthallisey
suggested changes
Jan 24, 2018
pkg/broker/binding_job.go
Outdated
| @@ -21,6 +21,7 @@ | |||
| package broker | |||
|
|
|||
| import ( | |||
| "github.com/apex/log" | |||
There was a problem hiding this comment.
Looks like github.com/apex snuck in there again
There was a problem hiding this comment.
Sigh I think it must be my goimports that auto runs. :(
maleck13
force-pushed
the
504-remove-need-for-setting-state-broker
branch
from
7b3035c
to
8948bc7
Compare
rthallisey
approved these changes
Jan 24, 2018
|
I think this needs a Bugzilla to merge. |
rthallisey
added
the
3.9 | release-1.1
|
Is the Bugzilla something I need to do? |
jmrodri
changed the title
|
@maleck13 I already had a bug relating to job state. Reusing that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes 504
@eriknelson I believe this change will stop the need to set the state in the broker and fix #504