Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

One CI fix and a few improvements #679

Merged
merged 6 commits into from
Jan 24, 2018
Merged

One CI fix and a few improvements #679

merged 6 commits into from
Jan 24, 2018

Conversation

rthallisey
Copy link
Contributor

@rthallisey rthallisey commented Jan 23, 2018 •
edited

Fix:

  • git diff FETCH_HEAD...$TRAVIS_BRANCH was always returning true. Instead, just use git diff $TRAVIS_BRANCH it will compare the diff from the current PR branch to the master branch.

Improvement:

  • Use the freshly built service-catalog images
  • Reduce service-catalog log-level to 2
  • Only gather logs from the service-catalog from the last 5 minutes.
  • List the docker images that travis has

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2018
@rthallisey rthallisey changed the title Testing travis Use just the branch name when running the git diff Jan 23, 2018
@rthallisey
Copy link
Contributor Author

@jmrodri slight amendment to the previous PR.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 24, 2018
@rthallisey rthallisey changed the title Use just the branch name when running the git diff One CI fix and a few improvements Jan 24, 2018
@rthallisey
Copy link
Contributor Author

Merging this with one ack since we need to unblock the gates.

@rthallisey rthallisey merged commit 5589139 into openshift:master Jan 24, 2018
@rthallisey rthallisey deleted the test branch January 24, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawn-hurley shawn-hurley shawn-hurley approved these changes

@jmrodri jmrodri Awaiting requested review from jmrodri

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rthallisey @shawn-hurley @openshift-ci-robot