Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1538732 - Adding ability for Subject Rules Review to do the correct check. #696

Merged
merged 1 commit into from Jan 27, 2018
Merged

Bug 1538732 - Adding ability for Subject Rules Review to do the correct check. #696

merged 1 commit into from Jan 27, 2018

Conversation

shawn-hurley
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 26, 2018
@jmrodri jmrodri self-requested a review January 27, 2018 20:10
jmrodri
jmrodri approved these changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

jmrodri
jmrodri approved these changes Jan 27, 2018
View reviewed changes
Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, verified change in master.

@jmrodri jmrodri merged commit f28bfbc into openshift:release-1.0 Jan 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmrodri jmrodri jmrodri approved these changes

Assignees
No one assigned
Labels
needs-review size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shawn-hurley @jmrodri @openshift-ci-robot