Bug 1538986 - Remove bad enum values from Update Request #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
size/S
This was referenced Jan 31, 2018
Closed
|
I think that this line also needs to get updated so that we return the 2xx when the new no parameters changes error occurs. |
|
@shawn-hurley I think this is no longer an issue with the most recent set of changes. |
shawn-hurley
requested changes
Feb 1, 2018
pkg/broker/broker.go
Outdated
| Method: apb.JobMethodUpdate, | ||
| }) | ||
|
|
||
| return &UpdateResponse{"noop-update"}, nil |
There was a problem hiding this comment.
This might seem silly, but this would be constantly overwriting the same job I believe. I wonder if generating a UUID for the token even for the noop might make sense?
shawn-hurley
approved these changes
Feb 1, 2018
|
@jmontleon needs a PR against release-1.1 branch to be included in 3.9 builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Fix a bug
Changes proposed in this pull request
Does this PR depend on another PR (Use this to track when PRs should be merged)
Doesn't depend on anything else.