Make the endpoints headless for local brokers #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Endpoints are real ip addresses that map to internal ip addresses. When using labels, we're associating the two which seems to cause the endpoint lose it's ip address. Instead, make the endpoint have no association to an app so it will always be around.
openshift-ci-robot
added
the
size/M
|
This is working great for me, so I can confirm it fixes #660 and I am now much happier 😃 @rthallisey what's up with CI, is that a valid failure? I've only just confirmed this allows me to work locally uninterupted. |
|
Ah, I see it was the vet problem from another PR. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
When using labels on the endpoint, we're associating the endpoint to an object that may not always be around, the locally running broker. This seems to cause the endpoint lose it's ip address. Instead, make the endpoint have no association to an app so it will always be around.
Changes proposed in this pull request
Which issue this PR fixes (This will close that issue when PR gets merged)
fixes #660