-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create broker-apb dir, add install yaml #916
Conversation
Assuming that this is an acceptable strategy. I'll be adding similar files to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me
LGTM to me too; so this is a set of k8s objects and not an openshift template? Also, do we want a branded "ansible-broker" version? I guess I'm wondering...what do we call ourselves upstream, because we're in a weird spot right now where our home is |
Set of k8s objects that can just be used...
I can update the yaml to make everything
I think this is a fair point, in Jason's PR to add the broker to origin you will see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so how do I use this to deploy my test broker image: docker.io/jmrodri/origin-ansible-service-broker:demo? trying to look ahead when template goes away.
@jmrodri My feeling is the best way, and the way that would make the template go away, would be for the whole broker-apb to be brought into this project. That would allow us to update the Makefile to 1) build the broker 2) build the broker-apb 3) provision with the broker-apb. I'm not certain that we would rely on this Do we still intend to run the broker locally? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay with me. This makes sense.
Originally, I had intended to bring in the entire broker-apb into this project so that I would be able to finish the versioning strategy blog post. All that really needs to exist for the blog post is the
install.yaml
. This PR adds that file where the broker-apb will live in the future without having to do all the work up front of moving the project, updating travis, and updating docker build automation.