Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create broker-apb dir, add install yaml #916

Merged
merged 2 commits into from
May 2, 2018

Conversation

djzager
Copy link
Member

@djzager djzager commented May 1, 2018

Originally, I had intended to bring in the entire broker-apb into this project so that I would be able to finish the versioning strategy blog post. All that really needs to exist for the blog post is the install.yaml. This PR adds that file where the broker-apb will live in the future without having to do all the work up front of moving the project, updating travis, and updating docker build automation.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 1, 2018
@djzager
Copy link
Member Author

djzager commented May 1, 2018

Assuming that this is an acceptable strategy. I'll be adding similar files to the release-1.0 and release-1.1 branches.

Copy link
Member

@dymurray dymurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me

@eriknelson
Copy link
Contributor

eriknelson commented May 1, 2018

LGTM to me too; so this is a set of k8s objects and not an openshift template? Also, do we want a branded "ansible-broker" version? I guess I'm wondering...what do we call ourselves upstream, because we're in a weird spot right now where our home is openshift/ansible-service-broker, and now we're starting to use yet-another-name. @jmrodri thoughts?

@djzager
Copy link
Member Author

djzager commented May 1, 2018

LGTM to me too; so this is a set of k8s objects and not an openshift template?

Set of k8s objects that can just be used...kubectl create -f install.yaml to get a broker.

Also, do we want a branded "ansible-broker" version?

I can update the yaml to make everything ansible-service-broker (except the APB image) if that helps.

I guess I'm wondering...what do we call ourselves upstream, because we're in a weird spot right now where our home is openshift/ansible-service-broker, and now we're starting to use yet-another-name. @jmrodri thoughts?

I think this is a fair point, in Jason's PR to add the broker to origin you will see automation-service-broker.

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so how do I use this to deploy my test broker image: docker.io/jmrodri/origin-ansible-service-broker:demo? trying to look ahead when template goes away.

@djzager
Copy link
Member Author

djzager commented May 2, 2018

@jmrodri My feeling is the best way, and the way that would make the template go away, would be for the whole broker-apb to be brought into this project. That would allow us to update the Makefile to 1) build the broker 2) build the broker-apb 3) provision with the broker-apb. I'm not certain that we would rely on this install.yaml for that, but that's how I believe we would deploy the broker in development.

Do we still intend to run the broker locally?

Copy link
Contributor

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with me. This makes sense.

@djzager djzager merged commit b236681 into openshift:master May 2, 2018
@djzager djzager deleted the add-apb-master branch May 2, 2018 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants