adding unit tests for broker package #983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XL
shawn-hurley
requested review from
eriknelson,
jmrodri and
rthallisey
and removed request for
eriknelson
shawn-hurley
added
tech-debt
3.11 | release-1.3
maleck13
reviewed
Jun 12, 2018
| dao: new(mocks.Dao), | ||
| config: Config{}, | ||
| addExpectations: func(d *mocks.Dao) { | ||
| d.On("GetServiceInstance", u.String()).Return(nil, unknownError) |
There was a problem hiding this comment.
just trying to understand. Is this specifying the behavior when the GetServiceInstance is called or is it the expected result?
There was a problem hiding this comment.
I think the answer is both.
https://github.com/stretchr/testify#mock-package
// TestSomething is an example of how to use our test object to
// make assertions about some target code we are testing.
func TestSomething(t *testing.T) {
// create an instance of our test object
testObj := new(MyMockedObject)
// setup expectations
testObj.On("DoSomething", 123).Return(true, nil)
// call the code we are testing
targetFuncThatDoesSomethingWithObj(testObj)
// assert that the expectations were met
testObj.AssertExpectations(t)
maleck13
reviewed
Jun 12, 2018
pkg/broker/jobs_test.go
Outdated
| } | ||
|
|
||
| second := messages[1] | ||
| log.Infof("second: %#v", second) |
There was a problem hiding this comment.
do we want to keep the log message?
maleck13
reviewed
Jun 12, 2018
pkg/broker/jobs_test.go
Outdated
| } | ||
|
|
||
| second := messages[1] | ||
| log.Infof("second: %#v", second) |
There was a problem hiding this comment.
same might want to remove
maleck13
approved these changes
Jun 12, 2018
djzager
approved these changes
Jun 12, 2018
jmrodri
approved these changes
Jun 13, 2018
dymurray
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does and why we need it:
Example of how to implement tests for the broker package.
Changes proposed in this pull request